Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popup] - Add close button #332

Merged
merged 2 commits into from
Jul 16, 2024
Merged

[Popup] - Add close button #332

merged 2 commits into from
Jul 16, 2024

Conversation

wazolab
Copy link
Contributor

@wazolab wazolab commented Jul 3, 2024

No description provided.

@wazolab wazolab added the enhancement New feature or request label Jul 3, 2024
@wazolab wazolab added this to the v1.23 milestone Jul 3, 2024
@wazolab wazolab requested a review from frodrigo July 3, 2024 13:49
@wazolab wazolab self-assigned this Jul 3, 2024
@wazolab wazolab linked an issue Jul 3, 2024 that may be closed by this pull request
[Popup] - Add close button #328
Closed
@wazolab wazolab force-pushed the 328-popup-add-close-button branch 2 times, most recently from ea91e29 to 5c7bc67 Compare July 3, 2024 14:05
@frodrigo
Copy link
Member

frodrigo commented Jul 3, 2024

Overlap issue

image

The current look and flee of the close button is not really fancy.

Maybe we can try something like this

image

A opacity (rounded) corner, with contrasted cross.

@wazolab wazolab force-pushed the 328-popup-add-close-button branch from 5c7bc67 to 6e798fc Compare July 4, 2024 12:44
@wazolab
Copy link
Contributor Author

wazolab commented Jul 4, 2024

I've made some changes !
About the overlap I added some padding on top of popup, but the real issue here is about CSS media-queries and is part of a larger work on Responsive Design.

@frodrigo
Copy link
Member

frodrigo commented Jul 4, 2024

image

image

@sbterito what do you think ?

@wazolab wazolab force-pushed the 328-popup-add-close-button branch 2 times, most recently from 65f0f50 to e848e18 Compare July 4, 2024 16:25
@wazolab wazolab force-pushed the 328-popup-add-close-button branch from e848e18 to 575a0f3 Compare July 16, 2024 09:53
@wazolab wazolab force-pushed the 328-popup-add-close-button branch 2 times, most recently from 2bd6223 to 5618659 Compare July 16, 2024 13:16
@wazolab wazolab force-pushed the 328-popup-add-close-button branch from 5618659 to 1787ee1 Compare July 16, 2024 13:18
@frodrigo frodrigo merged commit 427b4f0 into develop Jul 16, 2024
4 checks passed
@wazolab wazolab deleted the 328-popup-add-close-button branch July 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frodrigo frodrigo Awaiting requested review from frodrigo

Assignees

@wazolab wazolab

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

[Popup] - Add close button
2 participants
@wazolab @frodrigo