Loop cursor on all select-style prompts (#270)

terkelg · Sep 8, 2020 · abe3c01 · abe3c01
1 parent 6c51699
commit abe3c01
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/lib/elements/autocomplete.js b/lib/elements/autocomplete.js
@@ -152,14 +152,20 @@ class AutocompletePrompt extends Prompt {
   }
 
   up() {
-    if (this.select <= 0) return this.bell();
-    this.moveSelect(this.select - 1);
+    if (this.select === 0) {
+      this.moveSelect(this.suggestions.length - 1);
+    } else {
+      this.moveSelect(this.select - 1);
+    }
     this.render();
   }
 
   down() {
-    if (this.select >= this.suggestions.length - 1) return this.bell();
-    this.moveSelect(this.select + 1);
+    if (this.select === this.suggestions.length - 1) {
+      this.moveSelect(0);
+    } else {
+      this.moveSelect(this.select + 1);
+    }
     this.render();
   }
 

diff --git a/lib/elements/select.js b/lib/elements/select.js
@@ -83,14 +83,20 @@ class SelectPrompt extends Prompt {
   }
 
   up() {
-    if (this.cursor === 0) return this.bell();
-    this.moveCursor(this.cursor - 1);
+    if (this.cursor === 0) {
+      this.moveCursor(this.choices.length - 1);
+    } else {
+      this.moveCursor(this.cursor - 1);
+    }
     this.render();
   }
 
   down() {
-    if (this.cursor === this.choices.length - 1) return this.bell();
-    this.moveCursor(this.cursor + 1);
+    if (this.cursor === this.choices.length - 1) {
+      this.moveCursor(0);
+    } else {
+      this.moveCursor(this.cursor + 1);
+    }
     this.render();
   }