Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 6 #64

Closed
ranyitz opened this issue Jun 12, 2018 · 2 comments
Closed

Support node 6 #64

ranyitz opened this issue Jun 12, 2018 · 2 comments

Comments

@ranyitz
Copy link
Contributor

ranyitz commented Jun 12, 2018

Some projects still support node 6.

My use case is that I want to use prompts in jestjs/jest#6442

The solution for that could be fairly easy:

  1. Transpile the code using babel to dist
  2. Create a main file that will route between dist/index.js and lib/index.js according to the user's node version.
  3. Add another travis run using node 6.

It shouldn't interfere with the development, and there will be no performance change for users that use node > 8.

Let me know your thoughts.

@terkelg
Copy link
Owner

terkelg commented Jun 16, 2018

Sounds good to me. Do you have time to make a PR? It can be combined with #66. What do you think @lukeed? I just want the simplest possible build step

@ranyitz
Copy link
Contributor Author

ranyitz commented Jun 16, 2018

@terkelg Thanks! ❤️

I've added this PR #67

The build step is simple, just run npm run build which will only need to happen on CI. If you're publishing from your machine, just make sure to build before that, so the users will get an updated dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants