Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop engines field in package.json #66

Closed
ranyitz opened this issue Jun 16, 2018 · 2 comments
Closed

Drop engines field in package.json #66

ranyitz opened this issue Jun 16, 2018 · 2 comments

Comments

@ranyitz
Copy link
Contributor

ranyitz commented Jun 16, 2018

Thanks for this awesome project!

We are trying to use it inside of Jest, But Jest only supports node 6 and above. That's why I've opened #64

There is another option, suggested here jestjs/jest#6442 (comment). We'll use prompts without transpilation because it should run only on developers machines, which probably already have node > 8.

The only problem is that Jest still supports node version 6, and will fail if we'll use prompts as a dependency due to the engines property in package.json.

@terkelg Can we drop the engines restriction and add a manual message instead?

@terkelg
Copy link
Owner

terkelg commented Jun 19, 2018

Can you confirm everything is working?

@ranyitz
Copy link
Contributor Author

ranyitz commented Jun 19, 2018

Seems to be working perfectly, prompts now supports node > 6.

@terkelg Thanks 😄

@ranyitz ranyitz closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants