Added description option to choices (Fixes #165) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elie-g
force-pushed
the
choices-description
branch
from
b7b177b
to
483f39d
Compare
|
Gonna wait with the review then, until #168 has been merged |
|
Is this still relevant after #168 has been merged? We're almost ready to release the next version of Promtps 👍 |
|
Sorry! I was busy in the last few days. I'm working on it at the moment |
|
Done! ;) |
|
Thank you! I'm currently traveling. I'm going to merge this and release the next version when I get back 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it will duplicate the first lines if the description has more than one line. Though, this problem should be fixed once #168 is merged.
I'm gonna wait for #168 to be merged before doing the same for multiselect. In fact, it's already done for multiselect but I did not push it cause for some reason the first line does not print so I'll wait to see if #168 fixes this problem or if it changes anything.