Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kleur #263

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Update kleur #263

merged 1 commit into from
Nov 26, 2021

Conversation

alubbe
Copy link
Contributor

@alubbe alubbe commented Jun 23, 2020

Should be a safe upgrade (v6 compat was restored with 4.0.1)
Copy link
Collaborator

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only a risk for Node 13.0 to Node 13.6 (inclusive) since those versions of Node included different/experimental exports map support. Any version of Node between 6.x and 12.x (inclusive) will work, as will anything 13.7 and later.

Otherwise, the actual code is the same

@alubbe
Copy link
Contributor Author

alubbe commented Jul 6, 2020

Since node 13's support ended with the release of 14.0.0, I think this should be fine. And anyone on 13.0-13.6 can upgrade to 13.7-13.14

@terkelg
Copy link
Owner

terkelg commented Jul 7, 2020

Sounds like it's safe to update, right @lukeed?

@lukeed
Copy link
Collaborator

lukeed commented Jul 7, 2020

It should be, but you'd be amazed how many people are holding onto stale 13.x versions.

@g-plane
Copy link

g-plane commented Nov 6, 2020

Will the maintainer merge this PR and release a new version? Since PR is approved.

@terkelg terkelg merged commit a0c1777 into terkelg:master Nov 26, 2021
0x0a0d pushed a commit to 0x0a0d/prompts that referenced this pull request Feb 17, 2022
Should be a safe upgrade (v6 compat was restored with 4.0.1)
0x0a0d added a commit to 0x0a0d/prompts that referenced this pull request Feb 17, 2022
0x0a0d added a commit to 0x0a0d/prompts that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants