Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for EOL Node versions <14 #376

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

joeykilpatrick
Copy link
Contributor

@joeykilpatrick joeykilpatrick commented Dec 19, 2022

Removes support for Node.js versions 6.x.x and 8.x.x.

Node.js release schedule here.

Transition from Travis CI to GitHub Actions for testing for Node versions >= 14.

Benefits:

  • Removes babel dependencies and transpilation step
  • Allows for use of newer Node features (e.g. optional chaining, Array.at, nullish coalesce)

@terkelg

@joeykilpatrick joeykilpatrick marked this pull request as ready for review December 19, 2022 20:59
@terkelg
Copy link
Owner

terkelg commented Dec 20, 2022

Amazing – thank you @joeykilpatrick

Copy link
Owner

@terkelg terkelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Thank you for contributing 🎉

@terkelg terkelg requested a review from lukeed December 20, 2022 13:07
@terkelg
Copy link
Owner

terkelg commented Dec 20, 2022

@lukeed can you have a look at this real quick to confirm everything looks alright?

@terkelg terkelg merged commit 7c16709 into terkelg:master Dec 27, 2022
@terkelg
Copy link
Owner

terkelg commented Dec 27, 2022

Will be a part of the next release 👍

@lukeed
Copy link
Collaborator

lukeed commented Dec 27, 2022

chiming in for 2s, this will have to be a 3.0 release due to the minimum Node version bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants