Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #80

Merged
merged 15 commits into from
Aug 26, 2018
Merged

v1.0.0 #80

merged 15 commits into from
Aug 26, 2018

Conversation

terkelg
Copy link
Owner

@terkelg terkelg commented Aug 18, 2018

Other improvements/additions:

  • TextPrompt and NumberPrompt now have a validate option.
  • Better cursor in the AutocompletePrompt.
  • Updated documention

example

@terkelg
Copy link
Owner Author

terkelg commented Aug 18, 2018

Questions: Should we implement onCancel and onSubmit on a prompt level?

@tunnckoCore
Copy link

Yup, i think so.

@lukeed
Copy link
Collaborator

lukeed commented Aug 19, 2018

Should the invalid answer disappear? Might be good to keep showing it so that user can see what their mistake was

@terkelg
Copy link
Owner Author

terkelg commented Aug 19, 2018

I was thinking about that @lukeed. Not sure what's best. I just want to make sure people don't think it's validating as you type

@lukeed
Copy link
Collaborator

lukeed commented Aug 19, 2018

We can colorize the answer red while showing the fresh error message. That way there's also a visual cue on the input itself?

@terkelg
Copy link
Owner Author

terkelg commented Aug 19, 2018

yeah and have the default color return as you start typing. Good idea

@terkelg
Copy link
Owner Author

terkelg commented Aug 20, 2018

@lukeed if we color the answer on an error we can't clear the input tho

@lukeed
Copy link
Collaborator

lukeed commented Aug 20, 2018

@terkelg not sure what you mean? Recoloring the text should be possible, and I would enforce user to press backspace until clear. Then any value change (backspace or new additions) would reset the color.

Just my 2¢, can do whatever you feel works best 👍

@terkelg
Copy link
Owner Author

terkelg commented Aug 22, 2018

Can you guys please check the latest version?

@terkelg terkelg mentioned this pull request Aug 23, 2018
@terkelg terkelg merged commit 857bf91 into master Aug 26, 2018
@terkelg terkelg deleted the v1.0.0 branch February 18, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants