Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRIVIAL: The CACHE variable is not a constant #19

Merged
merged 1 commit into from
Apr 22, 2018
Merged

TRIVIAL: The CACHE variable is not a constant #19

merged 1 commit into from
Apr 22, 2018

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Apr 22, 2018 •
edited
Loading

What is the purpose of this pull request?

Unfortunately, I cannot set the flush option to true, because the CACHE variable is a constant and I got:

TypeError: Assignment to constant variable.

What changes did you make? (Give an overview)

  • Mark the CACHE variable as let instead of const.

@mrmlnc mrmlnc mentioned this pull request Apr 22, 2018
Closed
lukeed
lukeed approved these changes Apr 22, 2018
View reviewed changes
Copy link
Collaborator

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terkelg
Copy link
Owner

terkelg commented Apr 22, 2018 •
edited
Loading

Ah nice one. Thanks!

@terkelg terkelg merged commit 979e096 into terkelg:master Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrmlnc @terkelg @lukeed