Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no-glob patterns with absolute option correctly #38

Merged
merged 1 commit into from
Dec 2, 2018

Conversation

RedHatter
Copy link
Contributor

Patterns without globs ignore the absolute option.

@terkelg terkelg assigned lukeed and unassigned lukeed Dec 1, 2018
@terkelg terkelg requested a review from lukeed December 1, 2018 20:42
@terkelg
Copy link
Owner

terkelg commented Dec 1, 2018

Thanks! Can you review @lukeed?

Copy link
Collaborator

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lukeed lukeed merged commit 812091e into terkelg:master Dec 2, 2018
@lukeed
Copy link
Collaborator

lukeed commented Dec 2, 2018

We'd need you to publish a patch @terkelg

@terkelg
Copy link
Owner

terkelg commented Dec 2, 2018

Released in v0.2.4. @RedHatter can you make a PR for the sync-version too?

@RedHatter
Copy link
Contributor Author

Sure. Didn't realized there was a sync version. It should probably be documented?

@RedHatter RedHatter deleted the absolute-no-glob branch December 2, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants