Load file resource when used in a modular runtime image application. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 14, 2022 22:16
…her means. Useful for app package as a custom java runtime image.
renaudberube
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for the library to load file resource (not directory though) when it is run in a modular runtime image application that was created with JLink, using this plugin.
Because this library is not modular, it is merged into a single jar and ends up in the application main module. The relative path to resources stay the same but since they are now packaged within the "modules" file in the image, you have to use
ClassLoader.getResourceAsStream.The changes in this PR should not change the way this library behaves. All existing tests are passing.
You can find an example of a modular runtime image app using it at example