Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fry-current not working correctly with Rubinius #32

Closed
ghost opened this issue Dec 14, 2014 · 3 comments · Fixed by #34
Closed

fry-current not working correctly with Rubinius #32

ghost opened this issue Dec 14, 2014 · 3 comments · Fixed by #34

Comments

@ghost
Copy link

ghost commented Dec 14, 2014

$ fry use rbx-2
Switched to ruby 'rbx-2.4.1'
$ fry current
gems
$ fry version
0.1.2
@terlar
Copy link
Owner

terlar commented Dec 14, 2014

Sorry about that, I am working on some various fixes and restructure the code a bit, I am preparing for next release, so this is actually something inbetween 0.1.2 and 0.1.3. The issue here is that I have switched the order of the ruby bin path and the gems bin path.

Maybe you can tell me, which one should be first. Is the gem bins or ruby bin higher priority. Should the ruby or the gems be first in the PATH?

@ghost
Copy link
Author

ghost commented Dec 14, 2014

I think the gems bin should have higher priority.

@terlar
Copy link
Owner

terlar commented Dec 14, 2014

That is what I thought too, so that is why I moved it to the front. But that is not working with the current implementation for fry current, which assumes that first bin path that is matching the fry ruby path. So I will have to make sure it ignores the gems directory.

terlar added a commit that referenced this issue Dec 14, 2014
Since I moved the gempath before the ruby bin path the current
functionality didn't work since it relied on the first ruby found.

This adds a regression test to make sure it doesn't happen again.

Fixes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant