Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly use UTF-8 to store bytes for string data #42

Closed
terma opened this issue Jul 21, 2017 · 1 comment
Closed

Explicitly use UTF-8 to store bytes for string data #42

terma opened this issue Jul 21, 2017 · 1 comment
Assignees
@terma
Labels
bug

Comments

@terma
Copy link
Owner

terma commented Jul 21, 2017 •
edited
Loading

Currently all string conversion in StringData and CompressedXStringData rely on default charset which could be any. In case if default is ASCII during conversion some of characters could be corrupted. That affects save/load as well.
@terma terma added the bug label Jul 21, 2017
@terma terma self-assigned this Jul 21, 2017
terma added a commit that referenced this issue Jul 21, 2017
@terma
#42 internally encode all string as utf-8 byte[] instead of default (…
2873e2f 
…affect store)
terma added a commit that referenced this issue Jul 21, 2017
@terma
#42 internally encode all string as utf-8 byte[] instead of default (…
7bdcfb9 
…affect store) (#43)
@terma
Copy link
Owner Author

terma commented Jul 21, 2017

Fixed in 3.0.0

@terma terma closed this as completed Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terma terma

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terma