Add microdata to <nav> #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default navigation list template 'nav_default.html5' of Contao is adding microdata to the list items (itemprop url and itemprop name). Currently these Microdata inside the language links are hierarchically connected with the itemtype "WebPage" of the <body> element. This is wrong, because now all language links are interpreted as names and urls of the document itself. You can check this wrong connection and behaviour when testing any Contao site with installed ChangeLanguage in the microdata testing tool at https://search.google.com/structured-data/testing-tool This PR is adding the correct itemtype "SiteNavigationElement" to the wrapping <nav> Element of the language links to correct the wrong connection to the body itemtype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default navigation list template 'nav_default.html5' of Contao is adding microdata to the list items (itemprop url and itemprop name).
Currently these Microdata inside the language links are hierarchically connected with the itemtype "WebPage" of the < body > element. This is wrong, because now all language links are interpreted as names and urls of the document itself. You can check this wrong connection and behaviour when testing any Contao site with installed ChangeLanguage in the microdata testing tool at https://search.google.com/structured-data/testing-tool
This PR is adding the correct itemtype "SiteNavigationElement" to the wrapping < nav > Element of the language links to correct the wrong connection to the body itemtype.