Cast database ID to integer

[fritzmg]

Fixes #249

[CMSworker]

Thank you. I tested your changes, unfortunatelly still getting an error in some cases when trying to add a new article. Now the error states line 281.

Duplicating your code inside the if-statement at the beginning of the function seem to resolve it:

private function getChildTranslation(int $id, string $table, string $ptable, string $parentField): ?int
    {
        if (isset($this->translationCache[$table])) {
            
            // Cast ID to integer due to return type (#249)
            if (null !== ($this->translationCache[$table][$id] ?? null)) {
                $this->translationCache[$table][$id] = (int) $this->translationCache[$table][$id];
            }

            return $this->translationCache[$table][$id] ?? null;
        }

        $this->translationCache[$table] = $this->connection->fetchAllKeyValue(
            <<<SQL
                    SELECT
                        c.id,
                        IFNULL(ct.id, 0)
                    FROM $table c
                        JOIN $ptable p ON c.pid=p.id
                        LEFT JOIN $table ct ON c.languageMain=ct.id
                        LEFT JOIN $ptable pt ON p.$parentField=pt.id
                    WHERE pt.id > 0
                SQL,
        );

        // Cast ID to integer due to return type (#249)
        if (null !== ($this->translationCache[$table][$id] ?? null)) {
            $this->translationCache[$table][$id] = (int) $this->translationCache[$table][$id];
        }

        return $this->translationCache[$table][$id] ?? null;
    }

[fritzmg]

Hm that should not be necessary.

[aschempp]

I have fixed this differently in c7624ff. Your case would not apply to the early-return statement in the function.