-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.3.1 breaks conditions on second page with contao-mp_forms #44
Comments
I can confirm the problem. I have a fresh Contao 4.9 installation with the extensions mp_forms and conditional for testing. Nothing else is included. No JS or anything else. |
Can you elaborate on the problem? |
I have no Idea. You can try the clear Install and watch the console: https://bughunting.eccoweb.de/ |
Kannst du es mal mit der Datei probieren? https://pastebin.com/s50yif3j |
Wirft jetzt keinen Fehler mehr in der Console. Funktioniert initial. Nach Wechsel auf Seite zwei und dann zurück funktioniert es mal, mal nicht, das Feld zu schließen. |
@richardhj Can confirm the issue. Your fix from #44 (comment) works for me. |
@m-vo do you use mp_forms? |
Yes. (I only noticed the error in this combination.) |
#44 works with simple text fields. With hidden checkbox menus as mandatory field there are problems. https://bughunting.eccoweb.de/ |
Please checkout version 2.3.2 and provide feedback. Thanks! |
Looks good so far! |
Test case with mandatory checkbox menu does not work . |
What is the actual behavior and the intended behavior? |
User should make a selection. When clicked the fieldset Checkbox, the hidden field is displayed (mandatory). The mandatory field is hidden if user unchecked the fieldset Checkbox. But the form cannot be sent because the hidden mandatory field is invalid. Thus the user does not come any longer to step 2. It also makes no difference between uncheck all fields (hidden mandatory and fieldset checkbox). By default the hidden checkbox remains checked when it is hidden. You can see it on example page. |
Da mein Englisch Kraut und Rüben ist, hier nochmal eine Erklärung: Die Möglickeit ein Pflichfeld ein und auszublenden sollte in jedem Schritt gegeben sein, egal ob man neu mit der Eingabe beginnt, oder einen Schritt zurück geht, um Eingaben zu ändern. |
Das Ein- und Ausblenden des Feldes funktioniert ja aktuell. Aktuell schlägt die Servervalidierung fehl. Kannst du das bestätigen? |
Ja, ein und ausblenden klappt. Blendet man das Feld nach fehlgeschlagenem Sendeversuch wieder ein sieht man auch die error message "Bitte füllen Sie dieses Feld aus!". Es greift also die Validierung. |
Fixed in v2.3.3. |
We use conditionalformfields combined with mp_forms in contao 3.5. All conditions work on first page, on second page we get an js error in line 115:
We resolved this by now by rolling back to 2.3.0.
The text was updated successfully, but these errors were encountered: