Update the GitHub CI

terminal42 · Nov 16, 2023 · d9c692e · d9c692e
1 parent d7e68ce
commit d9c692e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -14,28 +14,26 @@ jobs:
     cs:
         name: Coding Style
         runs-on: ubuntu-latest
-        if: github.event_name != 'push'
         steps:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
 
             - name: Checkout
               uses: actions/checkout@v2
 
-            - name: Install ecs
-              run: cd tools/ecs && composer install --no-interaction --no-suggest
+            - name: Install the dependencies
+              run: composer install --no-interaction --no-suggest
 
             - name: Run the CS fixer
               run: composer cs-fixer
 
     tests:
         name: PHP ${{ matrix.php }}
         runs-on: ubuntu-latest
-        if: github.event_name != 'push'
         strategy:
             fail-fast: false
             matrix:
-                php: [8.1, 8.2]
+                php: [8.1, 8.2, 8.3]
         steps:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
@@ -45,9 +43,6 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v2
 
-            - name: Install phpunit
-              run: cd tools/phpunit && composer install --no-interaction --no-suggest
-
             - name: Install the dependencies
               run: composer install --no-interaction --no-suggest
 
@@ -57,11 +52,10 @@ jobs:
     prefer-lowest-tests:
         name: PHP ${{ matrix.php }} --prefer-lowest
         runs-on: ubuntu-latest
-        if: github.event_name != 'push'
         strategy:
             fail-fast: false
             matrix:
-                php: [8.1, 8.2]
+                php: [8.1, 8.2, 8.3]
         steps:
             - name: Setup PHP
               uses: shivammathur/setup-php@v2
@@ -71,9 +65,6 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v2
 
-            - name: Install phpunit
-              run: cd tools/phpunit && composer install --no-interaction --no-suggest
-
             - name: Install the dependencies
               run: composer update --prefer-lowest --prefer-stable --no-interaction --no-suggest
 

diff --git a/src/EventListener/InsertTagsListener.php b/src/EventListener/InsertTagsListener.php
@@ -27,6 +27,7 @@ public function __invoke(string $tag)
         $value = $chunks[3] ?? '';
 
         $manager = $this->formManagerFactory->forFormId((int) $formId);
+
         return match ($type) {
             'step' => $this->getStepValue($manager, $value),
             'field_value' => $manager->getDataOfAllSteps()->getAllSubmitted()[$value] ?? '',