-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS-ID/Class settings are ignored #13
Comments
It's rather a bug that there is a |
We can support both, I think 🤔 If you don't specify anything, we're not wrapping it in another |
Imho it should be configurable, whether or not a wrapper should be rendered (regardless of a given CSS ID or class). Similar to the articles of the Contao core. |
@fritzmg: but what, if you don't have enabled a wrapper and you add some CSS/ID-Class? Where do you render it then? |
If you want a wrapper, you need to enable the wrapper of course ;) |
Okay, that makes sense :-) |
The way I see it the following changes would need to be implemented:
|
@qzminski I'd prefer that option in the service - because in one project I was already missing that ;) (but it wasn't strictly necessary, so I made no such suggestion yet). |
It should not be there because a service is not responsible of generating any extra markup. You still have to display the buffer somewhere so it shouldn't be a big deal if you just add some extra HTML around it. |
Well, in essence I want a function or service that works the same (but better) as Contao's own |
If you add a content-node to an article, it would be great, if you would check if there are some expert-settings available (CSS-ID/Classes) and output them to the frontend.
Right now the ce_nodes.html template only includes:
<?= implode("\n", $this->nodes) ?>
and therefore the CSS-ID/Class settings are ignored.
I like it, that nothing else is added to the output, but in this case I would expect an additional div container.
Best regards,
Sares
The text was updated successfully, but these errors were encountered: