Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Version 1.4 not backwards compatible #8

Closed
leofeyer opened this issue Jan 17, 2018 · 14 comments
Closed

Version 1.4 not backwards compatible #8

leofeyer opened this issue Jan 17, 2018 · 14 comments

Comments

@leofeyer
Copy link

Using Contao 4.4 with version 1.4 of the header-replay-bundle breaks Contao's autologin functionality, therefore I assume that version 1.4 is not backwards compatible?

@Toflar
Copy link
Member

Toflar commented Jan 17, 2018

Imho it's fully BC, please provide more info.

@leofeyer
Copy link
Author

  • Install Contao 4.4 with version 1.3 of the header replay bundle.
  • Log in in the front end and create an autologin cookie.
  • Update to version 1.4 of the header replay bundle.
  • Make sure the PHP session cookie is gone (e.g. log out of the back end).
  • Open the front end.

Expected: I am logged in automatically.
Actual: I am not logged in automatically.

@leofeyer
Copy link
Author

In case it helps: if I reload the page twice (meaning upon the third request), I am actually logged in automatically with version 1.4. With version 1.3 I am logged in automatically upon the first request.

@aschempp
Copy link
Member

aschempp commented Jan 18, 2018 via email

@Toflar
Copy link
Member

Toflar commented Jan 18, 2018

The cookie is not lost, it's replayed onto the second request.

@aschempp
Copy link
Member

aschempp commented Jan 18, 2018 via email

@Toflar
Copy link
Member

Toflar commented Jan 18, 2018

Of course not, then it's just passed on to the application, not a problem of the bundle anymore.

@Toflar
Copy link
Member

Toflar commented Feb 13, 2018

I don't think there's ever been a BC break here but I've adjusted the way cookies are replayed in 1f1f504 so the upcoming 1.4.2 might fix your issue.

@Toflar
Copy link
Member

Toflar commented Feb 13, 2018

I tried to reproduce, works perfectly fine in both versions, 1.4.1 as well as the current 1.4.2 hotfix.

@Toflar
Copy link
Member

Toflar commented Feb 13, 2018

Even 1.4.0 works.

@joeherold
Copy link

@Toflar works, no problem so far with Contao 4.4.13 and "terminal42/header-replay-bundle": "dev-hotfix/1.4.2 as 1.3.2"

@joeherold
Copy link

ups, my auto login page runs on a different subdomain. so this will not reproduce the issue described by @leofeyer

@leofeyer
Copy link
Author

Now it works with version 1.4.1 on my system, too. WTF?

@Toflar
Copy link
Member

Toflar commented Feb 13, 2018

Ok, releasing then :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants