Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require terminal42/header-replay-bundle ^1.3 instead of 1.3.* #1341

Closed
wants to merge 1 commit into from
Closed

require terminal42/header-replay-bundle ^1.3 instead of 1.3.* #1341

wants to merge 1 commit into from

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jan 26, 2018

See composer/composer#7042

Why was it changed to 1.3.* anyway?

@m-vo
Copy link
Member

m-vo commented Jan 26, 2018

That's related to the reverts with the session issue I guess. IIRC version 1.4 fixed the problems with security (making the request a HEAD request), 1.4.1 reissues a request for invalid responses.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 26, 2018

Hm, I see. Then the contao/managed-edition for example should probably reintroduce

"conflict": {
    "contao/core-bundle": "<4.4.13"
}

into its composer.json, so that it prevents composer/composer#7042

Why was that removed anyway? 😁

@leofeyer
Copy link
Member

Why was it changed to 1.3.* anyway?

Because version 1.4 is not compatible with Contao 4.4.

Why was that removed anyway?

That should have been removed in Contao 4.5 only.

@leofeyer leofeyer added the bug label Jan 26, 2018
@leofeyer leofeyer added this to the 4.4.14 milestone Jan 26, 2018
@leofeyer leofeyer self-assigned this Feb 9, 2018
@leofeyer
Copy link
Member

leofeyer commented Feb 9, 2018

Re-added in contao/managed-edition@3742b02.

@leofeyer leofeyer closed this Feb 9, 2018
@fritzmg
Copy link
Contributor Author

fritzmg commented Feb 9, 2018

Shouldn't it be

"conflict": {
    "contao/core-bundle": "<4.4.13"
}

?

@fritzmg fritzmg deleted the patch-12 branch February 9, 2018 13:45
@leofeyer
Copy link
Member

leofeyer commented Feb 9, 2018

Why should it? The security issue has been fixed in version 4.4.9.

@fritzmg
Copy link
Contributor Author

fritzmg commented Feb 9, 2018

Well the issue was that with the most recent Contao Version two installable sets of packages were possible, thus a composer update switches back and forth between 4.4.12 and 4.4.13. If the managed-edition 4.4.14 only added

"conflict": {
    "contao/core-bundle": "<4.4.8"
}

wouldn't composer still switch between 4.4.12 and 4.4.14?

@leofeyer leofeyer removed this from the 4.4.14 milestone Feb 12, 2018
@leofeyer
Copy link
Member

This should be fixed in a540d1f now (also see terminal42/header-replay-bundle#8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants