Fix libxml2 warnings #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since libxml2 2.12.0, the error pointer is now const[1].
/usr/include/libxml2/libxml/xmlschemas.h:185:65: note: expected ‘xmlStructuredErrorFunc’ {aka ‘void (*)(void *, const struct _xmlError *)’} but argument is of type ‘void (*)(void *, xmlError *)’ {aka ‘void (*)(void *, struct _xmlError *)’}
Unfortunately, this is not a backward compatible change, and we can't
just add a const, as that would give a warning on <2.12.0 versions instead...
So add an #if.
You can find lots of code going through the same pain on GitHub[2].
[1] https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.12.0
[2] https://github.com/search?type=code&q=%23if+LIBXML_VERSION+21200
Fix this compiler warning:
./libxml2.go: In function ‘cleanup’:
./libxml2.go:116:5: warning: ‘xmlSchemaCleanupTypes’ is deprecated [-Wdeprecated-declarations]
116 | xmlSchemaCleanupTypes();
| ^~~~~~~~~~~~~~~~~~~~~
In file included from ./libxml2.go:9:
/usr/include/libxml2/libxml/xmlschemastypes.h:37:17: note: declared here
37 | xmlSchemaCleanupTypes (void);
| ^~~~~~~~~~~~~~~~~~~~~
We are probably safe to remove this call altogether, but let's do this
conservatively.
See [1][2].
[1] https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.10.0
[2] https://gitlab.gnome.org/GNOME/libxml2/-/commit/40483d0ce26119fd3b23aea6cce532a8a78670cf
xmlParseMemory is deprecated since v2.11.0[1][2]. Although it doesn't cause compiler warnings itself, it doesn't return line/column information UNLESS xmlLineNumbersDefault(1) is called, which IS deprecated AND causes compiler warnings. [1] https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.11.0 [2] https://gitlab.gnome.org/GNOME/libxml2/-/commit/0e49f8826a71be2c56b8f7e86a5c103dd21a8f3f
WGH-
force-pushed
the
fix-libxml2-warnings
branch
from
9c01790
to
6395660
Compare
|
Thanks for the commits and your detailed comments. I haven't tested them, but your comments seemed reasonable. |
What if I'm just an LLM? :) (just kidding, no, I'm not) |
|
Well that's why I didn't tag it with a version yet for I'm quite paranoid of getting spoofed by a LLM ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every commit has detailed description.
I've tested this on Docker images
golang:1.22-bullseye(libxml2 2.9.10),golang:1.22-bookworm(libxml2 2.9.14), and on my own system (libxml2 2.12.6).Closes #19