Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various LogArray improvements #41

Merged
merged 1 commit into from Mar 5, 2020
Merged

Conversation

spl
Copy link
Contributor

@spl spl commented Mar 5, 2020

  • More documentation
  • More tests
  • Consistent naming
  • More error checking
  • Better error reporting
  • Cleaned up and unified entry and decode functions
  • Cleaned up future-based functions (removed Box/dyn, used combinators)
  • Increased code coverage in tests
  • Fixed monotonic check

* More documentation
* More tests
* Consistent naming
* More error checking
* Better error reporting
* Cleaned up and unified entry and decode functions
* Cleaned up future-based functions
* Increased code coverage in tests
* Fixed monotonic check
@codecov-io
Copy link

Codecov Report

Merging #41 into master will decrease coverage by 0.12%.
The diff coverage is 74.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   77.16%   77.03%   -0.13%     
==========================================
  Files          21       21              
  Lines        7331     7478     +147     
  Branches      902      946      +44     
==========================================
+ Hits         5657     5761     +104     
- Misses        829      830       +1     
- Partials      845      887      +42
Impacted Files Coverage Δ
src/structure/adjacencylist.rs 84.79% <100%> (ø) ⬆️
src/structure/wavelettree.rs 81.59% <100%> (ø) ⬆️
src/structure/logarray.rs 74.3% <74.19%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665037d...72aee3b. Read the comment docs.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2020

It's interesting that Codecov shows that the coverage of logarray.rs has decreased. I worked a lot locally using grcov to increase it. I don't really understand Codecov's numbers, so I'm not sure what's happening.

@spl
Copy link
Contributor Author

spl commented Mar 5, 2020

Just to add to that, here's what I see from the grcov HTML output for logarray.rs:

Reference Line Coverage Functions
master (665037d) 86.5% (307/355) 55.0% (94/171)
logarray-improvement (72aee3b) 90.2% (453/502) 56.6% (138/244)

@matko
Copy link
Member

matko commented Mar 5, 2020

Wow, thanks a lot for this! You really made the code a lot easier to read.
Also, good job spotting that monotonic check bug.

I'm not entirely sure how the coverage is measured, but you definitely increased it, considering you added a whole bunch of tests. @rrooij any ideas?

I got no real improvements or review comments, so I'll just merge as is. Thanks again!

@matko matko merged commit e4c0f9b into terminusdb:master Mar 5, 2020
@spl spl deleted the logarray-improvement branch March 5, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants