Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflowError on ARM #2

Merged
1 commit merged into from
Aug 25, 2021
Merged

Fix StackOverflowError on ARM #2

1 commit merged into from
Aug 25, 2021

Conversation

w4123
Copy link

@w4123 w4123 commented Aug 25, 2021

@ghost
Copy link

ghost commented Aug 25, 2021

Thanks

@agnostic-apollo
Copy link
Member

agnostic-apollo commented Aug 25, 2021

Probably would be better to create a patch file with #ifdef __TERMUX__ like done in https://github.com/termux/termux-packages/blob/master/packages/openjdk-17/android11.patch directly in termux-packages

Edit: Already merged...

@w4123
Copy link
Author

w4123 commented Aug 25, 2021

It seems that this is not really a Termux-specific issue. The issue is also present in upstream OpenJDK as the original code simply doesn't work with clang. (Maybe I should PR too)

@ghost
Copy link

ghost commented Aug 25, 2021

I will convert this to patch since any changes are preferred to be stored with package build script.

@ghost ghost deleted a comment from Yisus7u7 Aug 25, 2021
@agnostic-apollo
Copy link
Member

The plan was that in future we may directly use upstream instead of this fork, so would be better to keep all changes in one place. The #ifdef __TERMUX__ was just an example, the clang/llvm is fine.

(Maybe I should PR too)

That would be even better.

khanhduytran0 added a commit to PojavLauncherTeam/mobile that referenced this pull request Oct 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants