Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to save file ownership in proot? #140

Closed
ghost opened this issue Dec 15, 2020 · 22 comments
Closed

Is it possible to save file ownership in proot? #140

ghost opened this issue Dec 15, 2020 · 22 comments

Comments

@ghost
Copy link

ghost commented Dec 15, 2020

Hello, is there a way to save file ownership in proot? something like File Metadata Store in proot
just like fakeroot does

In the curiosity, is it possible to add it on proot? or other hacks so it will change the file ownership inside PRoot or any extensions into it?

@ghost
Copy link
Author

ghost commented Dec 18, 2020

Nevermind, after googling about proot ownership, i compiled it with -DUSERLAND flag when Compiling proot and it works

I have a curiosity to ask, why this feature isn't enabled by default may i ask?

@ghost ghost closed this as completed Dec 18, 2020
@ghost ghost reopened this Dec 18, 2020
@SDRausty

This comment was marked as spam.

@SDRausty

This comment was marked as spam.

@ghost
Copy link
Author

ghost commented Dec 20, 2020

@SDRausty Yes, Clone the proot git,

go to
proot/src

Edit the GNUMakeFile

And add -DUSERLAND Flag to CPPFLAGS:

CPPFLAGS += -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -I. -I$(VPATH)

make V=1

And Profit.

@ghost
Copy link
Author

ghost commented Dec 20, 2020

File ownership is in normal proot version not associated with files, UserLAnd version does that, however that feature is behind compile time switch (-D USERLAND, although I'm usually not testing that version)

Originally posted by @michalbednarski in #126 (comment)

#126

Thanks, i already saw that issue, but the ownership emulation works but not perfect

@SDRausty

This comment was marked as spam.

@ghost
Copy link
Author

ghost commented Dec 20, 2020

Thank you for your cooperation @SDRausty but qemu-user is not nearly perfect in proot (i eventually lost motivation when running x86 as it's super slow and causes segfaults),

As for that, system emulation is preferable (yet slow but stable than user mode in overall)

@SDRausty

This comment has been minimized.

@SDRausty

This comment was marked as spam.

@ghost
Copy link
Author

ghost commented Dec 21, 2020

@SDRausty This should be done on Termux Environment (or Termux docker image) and not inside proot, as it's patched for Termux anyway

And you should have the dependencies installed for proot build and runtime:

libtalloc, make

@JanuszChmiel
Copy link

JanuszChmiel commented Dec 21, 2020 via email

@SDRausty

This comment was marked as spam.

@SDRausty

This comment was marked as spam.

@JanuszChmiel
Copy link

JanuszChmiel commented Dec 21, 2020 via email

SDRausty referenced this issue in TermuxArch/TermuxArch Dec 21, 2020
SDRausty referenced this issue in TermuxArch/TermuxArch Dec 21, 2020
SDRausty referenced this issue in TermuxArch/TermuxArch Dec 21, 2020
@SDRausty

This comment was marked as spam.

SDRausty referenced this issue in TermuxArch/TermuxArch Dec 21, 2020
@ghost
Copy link
Author

ghost commented Dec 22, 2020

Thank you @SDRausty, but it seems Userland does not use this anymore but thanks for implementing the unused proot feature

@corbinlc
Copy link
Contributor

We don't use it anymore in UserLAnd because it results in a significant performance hit. The average person wants the performance more than they need the real file ownership to be correct. There is probably some middle ground, but it should be optional to avoid the performance penalty when not needed.

@ghost
Copy link
Author

ghost commented Apr 14, 2021

Huh, but when i try it, it didn't cause any significant performance loss

@ghost
Copy link
Author

ghost commented Apr 15, 2021

ig this issue should be closed as i no longer use it,

@ghost ghost closed this as completed Apr 15, 2021
@JanuszChmiel
Copy link

JanuszChmiel commented Apr 15, 2021 via email

@SDRausty

This comment was marked as abuse.

@Grimler91
Copy link
Member

I don't know/remember who hid comments here, most likely they were considered off-topic

@termux termux locked as resolved and limited conversation to collaborators Feb 26, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants