Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base.yml main keys to be package manager (or other identifiable binary) names rather than repo-tags #61

Closed
nishakm opened this issue Jun 18, 2018 · 5 comments
Assignees
Milestone

Comments

@nishakm
Copy link
Contributor

nishakm commented Jun 18, 2018

The repo-tag is a container registry construct and could change depending on the registry. So look up the base commands based on the package manager rather than the repo tag.

Eg:

vmware/photon:
  latest: '1.0'
  tags:
    '1.0':
      shell: '/usr/bin/bash'
      names:

to

tdnf:
  repo: 'vmware/photon'
  tags: ['latest', '1.0']
  shell: '/usr/bin/bash'
  names:

This is to support #51

@nishakm nishakm added this to the Release 0.1.0 milestone Jun 18, 2018
@nishakm
Copy link
Contributor Author

nishakm commented Jun 18, 2018

@snmpboy Are you free to work on this issue? It's on a deadline so no pressure if you cannot commit.

@snmpboy
Copy link
Contributor

snmpboy commented Jun 18, 2018

@nishakm
Copy link
Contributor Author

nishakm commented Jun 18, 2018

@snmpboy no worries! Good luck with the networking study - that's intense!

@nishakm nishakm self-assigned this Jun 19, 2018
@nishakm
Copy link
Contributor Author

nishakm commented Jun 20, 2018

repo and tag may not be a good fit for this as they are representative of container distribution and not the contents. Values can be stored in the database instead.

nishakm pushed a commit that referenced this issue Jul 14, 2018
Changes to work with bare filesystem layers

Tern will now use overlayfs to apply diff filesystem layers one by one
and run commands against them in a chroot environment. This
allows us to isolate the context in with the diff filesystems are created
and hence have more accuracy on what packages are installed in
which layers.

This also allows us to inspect the true base filesystem of
the image that was built using a Dockerfile and if not, then try to
inspect just the base image that would be pulled from Dockerhub or
another container registry. This will also help us provide a raw
container image to inspect instead of just the Dockerfile.

Note that the tern executable will work as expected at this merge but
may not work elsewhere along the development branch.

Resolves #5 #17 #51 #60 #61 #63

Signed-off-by: Nisha K <nishak@vmware.com>
@nishakm
Copy link
Contributor Author

nishakm commented Jul 14, 2018

Closed in #67

@nishakm nishakm closed this as completed Jul 14, 2018
rnjudge pushed a commit to rnjudge/tern that referenced this issue Jun 5, 2020
Changes to work with bare filesystem layers

Tern will now use overlayfs to apply diff filesystem layers one by one
and run commands against them in a chroot environment. This
allows us to isolate the context in with the diff filesystems are created
and hence have more accuracy on what packages are installed in
which layers.

This also allows us to inspect the true base filesystem of
the image that was built using a Dockerfile and if not, then try to
inspect just the base image that would be pulled from Dockerhub or
another container registry. This will also help us provide a raw
container image to inspect instead of just the Dockerfile.

Note that the tern executable will work as expected at this merge but
may not work elsewhere along the development branch.

Resolves #5 tern-tools#17 tern-tools#51 tern-tools#60 tern-tools#61 tern-tools#63

Signed-off-by: Nisha K <nishak@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants