Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkg_format values for missing package managers in base.yml #994

Closed
rnjudge opened this issue Jul 6, 2021 · 2 comments · Fixed by #1014
Closed

Add pkg_format values for missing package managers in base.yml #994

rnjudge opened this issue Jul 6, 2021 · 2 comments · Fixed by #1014
Labels
GH Open Source Day Reserved for Grace Hopper Open Source Day participants good first issue A good first issue to tackle if you are new to the project

Comments

@rnjudge
Copy link
Contributor

rnjudge commented Jul 6, 2021

Description
pip, pip3, gem, npm, and go language package managers are all missing pkg_format values in tern/analyze/default/command_lib/base.yml. Now that the default report reports the pkg_format in the table, it's helpful to have these values so Tern can report on them.

To Do
Add the pkg_format values to base.yml.

Background
b8e7837
@rnjudge rnjudge added good first issue A good first issue to tackle if you are new to the project GH Open Source Day Reserved for Grace Hopper Open Source Day participants labels Jul 6, 2021
@nsapse
Copy link

nsapse commented Jul 15, 2021

I'd love to claim this issue for Open Source Day.

@nishakm nishakm added the assigned This issue has been assigned to someone who is actively working on it label Jul 15, 2021
@nishakm nishakm removed the assigned This issue has been assigned to someone who is actively working on it label Jul 15, 2021
@nishakm
Copy link
Contributor

nishakm commented Jul 15, 2021

@jayeritz is working on this issue

jayeritz added a commit to jayeritz/tern that referenced this issue Jul 15, 2021
@jayeritz
Add pkg_format values to base.yml
e52a440 
Now that the default report, reports the pkg_format in the table, the
missing pkg_format values were added so that Tern can report on them.

Resolves tern-tools#994

Signed-off-by: Jamila Ritter jamila.ritter@rutgers.edu
jayeritz added a commit to jayeritz/tern that referenced this issue Jul 15, 2021
@jayeritz
Add pkg_format values to base.yml
0ae2a68 
Now that the default report reports the pkg_format in the table, the
missing pkg_format values were added so that Tern can report on them.

Resolves tern-tools#994

Signed-off-by: Jamila Ritter <jamila.ritter@rutgers.edu>
@jayeritz jayeritz mentioned this issue Jul 15, 2021
Merged
rnjudge pushed a commit that referenced this issue Jul 16, 2021
@jayeritz @rnjudge
Add pkg_format values to base.yml
c6d26fa 
Now that the default report reports the pkg_format in the table, the
missing pkg_format values were added so that Tern can report on them.

Resolves #994

Signed-off-by: Jamila Ritter <jamila.ritter@rutgers.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GH Open Source Day Reserved for Grace Hopper Open Source Day participants good first issue A good first issue to tackle if you are new to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pkg_format values to base.yml jayeritz/tern
3 participants
@nishakm @nsapse @rnjudge