Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prospector 1.4.1 fixes #1033

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Prospector 1.4.1 fixes #1033

merged 1 commit into from
Sep 2, 2021

Conversation

nishakm
Copy link
Contributor

@nishakm nishakm commented Sep 1, 2021

Major changes:

  • Return None in mount_single_layer function when something goes
    wrong. Do a check for the target_dir string existing before passing
    it on for analysis.
  • Return None for DriverManager try-except calls when there is a
    NoMatches exception. This modifies all instantiations of Stevedore's
    DriverManager class.
  • Iterate over the dictionary using .items() rather than just the plain
    dictionary.
  • Use "with" to open files and subprocess pipes. This may result in
    certain errors not being raised, but it is hard to know at this
    point.

Minor changes:

  • Used the "maxsplit" argument in main.py as we only need the
    first item.
  • Used [] rather than list() to initialize lists.
  • Specify encoding as 'utf-8' when opening files.
  • Update re-raises to explicitly state which exception they are
    re-raising from using "from".
  • Use "enumerate" for looping through list's index while throwing
    out the unused value.
  • Suppressed the "useless-suppression" message along with
    "too-many-branches" suppression due to pylint bug:
    useless-suppression false positive with ungrouped-imports pylint-dev/pylint#2366
  • Wraped some lines that were too long, except in the HTML format
    file due to the need to keep the literal HTML formatting.
  • Updated the year on some modified files.

Signed-off-by: Nisha K nishak@vmware.com

Major changes:
- Return None in mount_single_layer function when something goes
  wrong. Do a check for the target_dir string existing before passing
  it on for analysis.
- Return None for DriverManager try-except calls when there is a
  NoMatches exception. This modifies all instantiations of Stevedore's
  DriverManager class.
- Iterate over the dictionary using .items() rather than just the plain
  dictionary.
- Use "with" to open files and subprocess pipes. This may result in
  certain errors not being raised, but it is hard to know at this
  point.

Minor changes:
- Used the "maxsplit" argument in __main__.py as we only need the
  first item.
- Used [] rather than list() to initialize lists.
- Specify encoding as 'utf-8' when opening files.
- Update re-raises to explicitly state which exception they are
  re-raising from using "from".
- Use "enumerate" for looping through list's index while throwing
  out the unused value.
- Suppressed the "useless-suppression" message along with
  "too-many-branches" suppression due to pylint bug:
  pylint-dev/pylint#2366
- Wraped some lines that were too long, except in the HTML format
  file due to the need to keep the literal HTML formatting.
- Updated the year on some modified files.

Signed-off-by: Nisha K <nishak@vmware.com>
@rnjudge rnjudge merged commit 4c4b2a8 into tern-tools:main Sep 2, 2021
@nishakm nishakm deleted the prospector-1.4.1 branch January 13, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants