Parsing ARG varibales #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnjudge
reviewed
Mar 12, 2020
|
@ForgetMe17 could you update your commit message? |
rnjudge
requested changes
Mar 13, 2020
ForgetMe17
force-pushed
the
pin_arg_command
branch
from
f022832
to
c1541ed
Compare
|
Thanks for your review. Sorry for the misspelling, i will be more careful. |
|
@ForgetMe17 no worries! You're doing great! One request I would like to make is to add more description about what you did to resolve the issue in the commit message. It's a significant change and a lot of work :) |
rnjudge
approved these changes
Mar 16, 2020
Replace the arg variables in the dockerfile if known. In tern/analyze/docker/dockerfile.py, add function expand_arg which finds the defination of ARG variables and replace them using function replace_env. Add test dockerfile tests/dockerfiles/buildpack_deps_jessie_arg. Add a testcase in tests/dockerfiles/buildpack_deps_jessie_arg.: Work towards tern-tools#508. Signed-off-by: WangJL <hazard15020@gmail.com>
ForgetMe17
force-pushed
the
pin_arg_command
branch
from
c1541ed
to
5c3ef8d
Compare
|
@rnjudge OK to merge? |
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the arg varibles in the dockerfile if known.
Work towards #508.
Signed-off-by: WangJL hazard15020@gmail.com