Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #39

Merged
merged 4 commits into from Jan 24, 2022
Merged

Fixes #39

merged 4 commits into from Jan 24, 2022

Conversation

ternaus
Copy link
Owner

@ternaus ternaus commented Jan 24, 2022

No description provided.

@sourcery-ai sourcery-ai bot mentioned this pull request Jan 24, 2022
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 24, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 4.05 ⭐ 4.05 ⭐ 0.00
Method Length 91.71 🙂 91.67 🙂 -0.04 👍
Working memory 12.67 😞 12.67 😞 0.00
Quality 55.34% 🙂 55.34% 🙂 0.00%
Other metrics Before After Change
Lines 911 911 0
Changed files Quality Before Quality After Quality Change
retinaface/init.py 100.00% ⭐ 100.00% ⭐ 0.00%
retinaface/box_utils.py 64.71% 🙂 64.74% 🙂 0.03% 👍
retinaface/inference.py 47.36% 😞 47.36% 😞 0.00%
retinaface/predict_single.py 44.97% 😞 44.97% 😞 0.00%
retinaface/train.py 65.95% 🙂 65.95% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
retinaface/inference.py predict 13 🙂 349 ⛔ 20 ⛔ 27.25% 😞 Try splitting into smaller methods. Extract out complex expressions
retinaface/inference.py process_predictions 8 ⭐ 355 ⛔ 19 ⛔ 32.32% 😞 Try splitting into smaller methods. Extract out complex expressions
retinaface/predict_single.py Model.predict_jsons 6 ⭐ 388 ⛔ 17 ⛔ 35.30% 😞 Try splitting into smaller methods. Extract out complex expressions
retinaface/train.py RetinaFace.validation_step 8 ⭐ 324 ⛔ 15 😞 36.77% 😞 Try splitting into smaller methods. Extract out complex expressions
retinaface/box_utils.py match 2 ⭐ 174 😞 18 ⛔ 47.71% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ternaus ternaus merged commit b72317d into master Jan 24, 2022
@ternaus ternaus deleted the fixes branch January 24, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant