#733 Union type between a callback and another type is broken in a definition #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a definition
This was referenced Mar 25, 2016
|
Please up @marijnh |
I mean, not sure how to write auto-tests, sorry. The patch actually fixes the test case issue #733 (checked manually) |
|
@marijnh up please. |
marijnh
added a commit
that referenced
this pull request
Apr 8, 2016
|
I've pushed alternative patch d039c3c, which factors the logic into a function. |
|
Thanks Florent |
sergioramos
pushed a commit
to atg/tern
that referenced
this pull request
Apr 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to test it. Also don't hesitate to improve the patch to your liking.
Cheers,
Florent