Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pob mempool #236

Merged
merged 1 commit into from Dec 29, 2023
Merged

fix: update pob mempool #236

merged 1 commit into from Dec 29, 2023

Conversation

javiersuweijie
Copy link
Member

@javiersuweijie javiersuweijie commented Dec 29, 2023

The previous POB mempool was allowing transactions to be included even though the sum of transactions gas requested was more than the block limit.

skip-mev/pob@v1.0.4...v1.0.5

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86994e5) 68.21% compared to head (d5a5f3a) 68.28%.
Report is 3 commits behind head on release/v2.6.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v2.6     #236      +/-   ##
================================================
+ Coverage         68.21%   68.28%   +0.06%     
================================================
  Files                43       43              
  Lines              2322     2327       +5     
================================================
+ Hits               1584     1589       +5     
  Misses              583      583              
  Partials            155      155              

see 1 file with indirect coverage changes

@gregnuj gregnuj merged commit 23e5d6e into release/v2.6 Dec 29, 2023
9 checks passed
@gregnuj gregnuj deleted the fix/pob-mempool branch March 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants