Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: alliance v0.3.4 #266

Merged
merged 2 commits into from Feb 29, 2024
Merged

upgrade: alliance v0.3.4 #266

merged 2 commits into from Feb 29, 2024

Conversation

javiersuweijie
Copy link
Member

@javiersuweijie javiersuweijie commented Feb 28, 2024

Upgrade alliance to use v0.3.4. This is a consensus breaking change

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.50%. Comparing base (afd2aac) to head (06d1d00).
Report is 17 commits behind head on release/v2.10.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release/v2.10     #266   +/-   ##
==============================================
  Coverage          70.50%   70.50%           
==============================================
  Files                 45       45           
  Lines               2092     2092           
==============================================
  Hits                1475     1475           
  Misses               451      451           
  Partials             166      166           

see 2 files with indirect coverage changes

Copy link
Contributor

@emidev98 emidev98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR,

@hoank101
Copy link

hi @javiersuweijie
i see everything look good, can you show me why consensus breaking?

@javiersuweijie
Copy link
Member Author

hi @javiersuweijie i see everything look good, can you show me why consensus breaking?

Hey! The upgrade to alliance https://github.com/terra-money/alliance/releases/tag/v0.4.3 has some changes to how rewards are calculated.

@hoank101
Copy link

hi @javiersuweijie i see everything look good, can you show me why consensus breaking?

Hey! The upgrade to alliance https://github.com/terra-money/alliance/releases/tag/v0.4.3 has some changes to how rewards are calculated.

thank you

@tuky191 tuky191 merged commit 21a3d49 into release/v2.10 Feb 29, 2024
8 checks passed
@emidev98 emidev98 deleted the upgrade/alliance-0.3.4 branch February 29, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants