Skip to content
This repository has been archived by the owner on Feb 16, 2021. It is now read-only.

v1.1 #2

Merged
merged 18 commits into from
Mar 9, 2020
Merged

v1.1 #2

merged 18 commits into from
Mar 9, 2020

Conversation

ouiliame
Copy link
Contributor

@ouiliame ouiliame commented Mar 9, 2020

  • Add ParamsChange with support for all module subspaces including gov. Makes it easy to define Parameter Changes for ParameterChangeProposal.

  • Add coin_type option for Mnemonic Key for legacy HD path wallet support.

  • Add Wallet.sign_tx alias for Wallet.key.sign_tx

@ouiliame ouiliame requested a review from yun-yeo March 9, 2020 06:18
@ouiliame ouiliame added the enhancement New feature or request label Mar 9, 2020
@ouiliame ouiliame requested a review from hanjukim March 9, 2020 06:36
yun-yeo
yun-yeo approved these changes Mar 9, 2020
View reviewed changes
Copy link

@yun-yeo yun-yeo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting version PR into multiple feature PRs is better to managing repository like following

[feature] param change support
[feature] old code type support

code itself looks good
utACK

@ouiliame ouiliame merged commit 037ea34 into master Mar 9, 2020
@hanjukim hanjukim deleted the hotfix_1.1 branch November 18, 2020 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yun-yeo yun-yeo yun-yeo approved these changes

@hanjukim hanjukim Awaiting requested review from hanjukim

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ouiliame @yun-yeo