Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic: Parity of WASM Messages #353

Merged
merged 3 commits into from Jun 12, 2023

Conversation

fragwuerdig
Copy link
Contributor

@fragwuerdig fragwuerdig commented Jun 4, 2023

The so-called "parity upgrade" on Terra Classic is bringing the message format and type URLs of wasmd related messages to parity with Terra. This PR contains:

  • Update of all smart contract related messages to ignore isClassic flag
  • Retain isClassic flag for compatibility
  • Tested manually with local script
  • Remove legacy test case as deprecated

Note, that we did not include updates for the wasm related proposal types, because the governance facilities of wasmd will not be enabled during this upgrade. Please, review and consider to backport it to current release branch of terra.js, so it can be used in station mobile. Thank you.

@alecande11
Copy link
Member

Hey, overall it looks good, just one thing, can you rename all the _isClassic into just _, so it's a bit more consistent with the other messages.
Same on the feather.js PR.

I would do it but I don't have write access to the branch.

@fragwuerdig
Copy link
Contributor Author

Ok. Renamed. Thanks for your reply.

@alecande11
Copy link
Member

Thank you @fragwuerdig !
One more thing, how do you prefer us to handle the Station update?

If we deploy it before the on-chain upgrade users won't be able to interact with the wasm module until the chain is updated, and if we do it after users wont be able to do it until Station is deployed...
Especially on the extension which can take several days to deploy (due to Google approval time).

Either way there is going to be some downtime for the users, but I wanted to check which option works better for you.

@fragwuerdig
Copy link
Contributor Author

fragwuerdig commented Jun 8, 2023

I think as soon as possible after 14th will suffice. We are going to have downtime either way. Thank you very much!

@alecande11 alecande11 merged commit 036a47f into terra-money:main Jun 12, 2023
@inon-man inon-man deleted the wasm-parity branch June 14, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants