-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TQ42-1428 Create a Jupyter notebook sample for sequential generic TSP model application #89
base: main
Are you sure you want to change the base?
Conversation
" )\n", | ||
" ),\n", | ||
" inputs=TSEvalInputsProto(\n", | ||
" model=ModelStorageInfoProto(storage_id=\"ENTER_MODEL_STORAGE_ID_HERE\"),\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does the user need to input the model id? Couldn't you just derive it from the training experiment run??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used run.data.id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you do not understand.... Use the model id you get from the training run to fill this in here...
notebooks/ts_generic_example.ipynb
Outdated
"source": [ | ||
"# Show the results\n", | ||
"\n", | ||
"print(ExperimentRun(client=client, id=\"ENTER_EXPERIMENT_RUN_ID_HERE\").data) " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have the id already from the run you created above.....
01d438c
to
7f1439a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not resolve comments if these are not 100% resolved....
"source": [ | ||
"# Show the results\n", | ||
"\n", | ||
"print(ExperimentRun(client=client, id=run.data.id).data) " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just do print(run.data)
? 😆
You already have an ExperimentRun
instance...
"outputs": [], | ||
"source": [ | ||
"# Show the results\n", | ||
"print(ExperimentRun(client=client, id=run.data.id).data) " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just do print(run.data)? 😆
You already have an ExperimentRun instance...
" )\n", | ||
" ),\n", | ||
" inputs=TSEvalInputsProto(\n", | ||
" model=ModelStorageInfoProto(storage_id=\"ENTER_MODEL_STORAGE_ID_HERE\"),\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No you do not understand.... Use the model id you get from the training run to fill this in here...
add inference steps into ts_generic_example.ipynb