Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TQ42-1428 Create a Jupyter notebook sample for sequential generic TSP model application #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lusnig
Copy link
Contributor

@lusnig lusnig commented Jun 5, 2024

add inference steps into ts_generic_example.ipynb

" )\n",
" ),\n",
" inputs=TSEvalInputsProto(\n",
" model=ModelStorageInfoProto(storage_id=\"ENTER_MODEL_STORAGE_ID_HERE\"),\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does the user need to input the model id? Couldn't you just derive it from the training experiment run??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used run.data.id

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you do not understand.... Use the model id you get from the training run to fill this in here...

notebooks/ts_generic_example.ipynb Outdated Show resolved Hide resolved
"source": [
"# Show the results\n",
"\n",
"print(ExperimentRun(client=client, id=\"ENTER_EXPERIMENT_RUN_ID_HERE\").data) "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have the id already from the run you created above.....

notebooks/ts_generic_example.ipynb Show resolved Hide resolved
notebooks/ts_generic_example.ipynb Outdated Show resolved Hide resolved
@lusnig lusnig force-pushed the TQ42-1428-create-a-jupyter-notebook-sample-for-sequential-generic-tsp-model-application branch from 01d438c to 7f1439a Compare June 6, 2024 14:18
Copy link
Collaborator

@sbtq sbtq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not resolve comments if these are not 100% resolved....

"source": [
"# Show the results\n",
"\n",
"print(ExperimentRun(client=client, id=run.data.id).data) "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just do print(run.data)? 😆
You already have an ExperimentRun instance...

"outputs": [],
"source": [
"# Show the results\n",
"print(ExperimentRun(client=client, id=run.data.id).data) "
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just do print(run.data)? 😆
You already have an ExperimentRun instance...

" )\n",
" ),\n",
" inputs=TSEvalInputsProto(\n",
" model=ModelStorageInfoProto(storage_id=\"ENTER_MODEL_STORAGE_ID_HERE\"),\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No you do not understand.... Use the model id you get from the training run to fill this in here...

notebooks/ts_generic_example.ipynb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants