Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dns ttl as variable #54

Merged
merged 2 commits into from
Jun 24, 2020
Merged

feat: add dns ttl as variable #54

merged 2 commits into from
Jun 24, 2020

Conversation

tomasbackman
Copy link
Contributor

Description

This is a PR with same changes as in:
#35
Originally done by @rafaelkonrath

Motivation and Context

There is a small PR about this already but suggested changes and rebase/merge for it has not been done yet so I redid same, since I have some interest in this =) hopefully not stepping on anyones toes here.

Breaking Changes

No

How Has This Been Tested?

Same changes as has been reviewed by @bryantbiggs and more or less accepted then =)

@bryantbiggs
Copy link
Member

thank you @tomasbackman - would you mind running the precmomit hook to update the documentation please?

@tomasbackman
Copy link
Contributor Author

@bryantbiggs I guess I can try, but what hook is that? And how do I run it? I don't see any mention of any hook in neither the contributing guidelines nor the readme so Im not really sure on how..

It sounds like it is about updating the documentations? I guess I could do that manually as well, but yes a tool for it would be nice =)

@bryantbiggs
Copy link
Member

thanks @tomasbackman - we'll have to take a look at updating the docs for that. you should have seen something show up on your cli when running git commit. here is a link to the project we typically use on these modules https://github.com/antonbabenko/pre-commit-terraform - at minimum you just need

once those are available on your machine its just a matter of running manually with pre-commit run -a or if you make changes to the codebase and run git commit the hook will kick in to fire also

@bryantbiggs
Copy link
Member

@antonbabenko 👍

@antonbabenko antonbabenko merged commit ad0b27c into terraform-aws-modules:master Jun 24, 2020
@antonbabenko
Copy link
Member

Great!

v2.9.0 has been released.

@bryantbiggs bryantbiggs mentioned this pull request Jun 24, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants