Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add support for feature flag #8

Merged
merged 9 commits into from
Oct 30, 2023
Merged

feat!: Add support for feature flag #8

merged 9 commits into from
Oct 30, 2023

Conversation

mlnrt
Copy link
Contributor

@mlnrt mlnrt commented Jul 24, 2023 •
edited by bryantbiggs
Loading

Description

  • Add support for type argument
  • Bump minimum supported version of Terraform and AWS provider to 1.0 and 5.0 respectively
  • Update default output value to null

Motivation and Context

The current version does not allow the configuration of AppConfig hosted Feature Flags

Breaking Changes

  • Yes - minimum support version bump

How Has This Been Tested?

A new Feature Flag example has been created with its configuration set in examples/_configs/feature_flag.json

bryantbiggs
bryantbiggs reviewed Aug 31, 2023
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
bryantbiggs
bryantbiggs reviewed Aug 31, 2023
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs changed the title feat: Add support for Feature Flag feat!: Add support for feature flag Aug 31, 2023
@bryantbiggs
Copy link
Member

@mlnrt are you still interested in carrying these changes forward?

@mlnrt
Copy link
Contributor Author

mlnrt commented Oct 11, 2023

@bryantbiggs sorry I have been very busy the past two months and will stay busy for few weeks. Can this wait a little more?

bryantbiggs
bryantbiggs approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 44f1a5d into terraform-aws-modules:master Oct 30, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 30, 2023
@semantic-release-bot
chore(release): version 2.0.0 [skip ci]
cb99d1b 
## [2.0.0](v1.1.4...v2.0.0) (2023-10-30)

### ⚠ BREAKING CHANGES

* Add support for feature flag (#8)

### Features

* Add support for feature flag ([#8](#8)) ([44f1a5d](44f1a5d))
@antonbabenko
Copy link
Member

This PR is included in version 2.0.0 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlnrt @bryantbiggs @antonbabenko