Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gitlab versioning errors with terraform 0.13 #344

Conversation

dynamike
Copy link
Member

Description

This will hopefully fix the pre-commit issues popping up in #343

Motivation and Context

To fix broken pre-commits

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@dynamike dynamike changed the title Fix: gitlab versioning errors with terraform 0.13 fix: gitlab versioning errors with terraform 0.13 May 11, 2023
@dynamike dynamike changed the title fix: gitlab versioning errors with terraform 0.13 fix: Gitlab versioning errors with terraform 0.13 May 11, 2023
@dynamike dynamike force-pushed the mk-fix-gitlab-required-version branch from 2dacbb4 to 261c04c Compare May 11, 2023 21:33
@dynamike
Copy link
Member Author

@bryantbiggs Can I get eyes on this? Hopefully it should help fix some downstream PRs that have been piling up.

@antonbabenko antonbabenko merged commit 359ab38 into terraform-aws-modules:master May 12, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request May 12, 2023
### [3.26.1](v3.26.0...v3.26.1) (2023-05-12)

### Bug Fixes

* Gitlab versioning errors with terraform 0.13 ([#344](#344)) ([359ab38](359ab38))
@antonbabenko
Copy link
Member

This PR is included in version 3.26.1 🎉

@dynamike dynamike deleted the mk-fix-gitlab-required-version branch May 12, 2023 13:33
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants