Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow multiple step adjustments for step scaling and v5.0 provider upgrade #240

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jul 23, 2023

Description

Step scaling allows for multiple step adjustments to be configured.
Also bumped module to terraform v1.0 and aws provider v5.0.

Motivation and Context

Resolves: #236

Breaking Changes

Yes, anyone previously specifying step_adjustments will need to change step_adjustment config from a map to a list of maps as shown in the updated example.

Also aws provider v5.0 upgrade.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum changed the title fix: Allow multiple step adjustments for step scaling fix: Allow multiple step adjustments for step scaling and v5.0 provider upgrade Jul 23, 2023
@bryantbiggs
Copy link
Member

FYI - if we take a breaking change, we should make all breaking changes at once to reduce the amount of disruption #204

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 23, 2023
@magreenbaum
Copy link
Member Author

Unstale

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 23, 2023
@magreenbaum
Copy link
Member Author

unstale

@bryantbiggs
Copy link
Member

resolved in #204

@bryantbiggs bryantbiggs closed this Oct 9, 2023
@antonbabenko
Copy link
Member

This issue has been resolved in version 7.0.0 🎉

@magreenbaum magreenbaum deleted the allow_for_multiple_step_adjustments branch October 9, 2023 19:08
Copy link

github-actions bot commented Nov 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaling_policies doesn't allow for multiple step_adjustments
3 participants