Skip to content

Commit

Permalink
Fix incorrect subnet_id output expression
Browse files Browse the repository at this point in the history
This was always producing an error, but prior to Terraform 0.11 these errors were suppressed and shown only in the logs.

Now that Terraform 0.11 shows errors in outputs, they must all be valid in order to use this module.
  • Loading branch information
apparentlymart committed Nov 15, 2017
1 parent ee9c7ad commit 0f3d09c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion outputs.tf
Expand Up @@ -60,5 +60,5 @@ output "vpc_security_group_ids" {

output "subnet_id" {
description = "List of IDs of VPC subnets of instances"
value = ["${aws_instance.this.*.}"]
value = ["${aws_instance.this.*.subnet_id}"]
}

2 comments on commit 0f3d09c

@tehmaspc
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apparentlymart - could the issue w/ subnet_id you fixed here and TF 0.11 be the reason I see this now with this module?:

cc @antonbabenko

1 error(s) occurred:

* module.mgt_REDACTED_01.output.placement_group: Resource 'aws_instance.this' does not have attribute 'placement_group' for variable 'aws_instance.this.*.placement_group'

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

@antonbabenko
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.