Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing 'Name' tag in var.tags is overridden #53

Closed
metmajer opened this issue Oct 12, 2018 · 4 comments · Fixed by #66
Closed

Existing 'Name' tag in var.tags is overridden #53

metmajer opened this issue Oct 12, 2018 · 4 comments · Fixed by #66

Comments

@metmajer
Copy link

A tag Name is merged into the incoming var.tags, independent of whether this key is already contained or not: https://github.com/terraform-aws-modules/terraform-aws-ec2-instance/blob/master/main.tf#L37.

I assume that by flipping the arguments of the merge() function, var.tags would get the precedence it needs?
@metmajer metmajer changed the title 'Name' tag in var.tags is overridden Existing 'Name' tag in var.tags is overridden Oct 12, 2018
@metmajer
Copy link
Author

Is this the intended behavior? Any thoughts on this? Cheers

@antonbabenko
Copy link
Member

You are right, Martin, they have to be swapped. I will make a change now.

antonbabenko added a commit that referenced this issue Jan 27, 2019
@antonbabenko
Tags should be possible to override (fixed #53)
2e6ddcd
@antonbabenko antonbabenko mentioned this issue Jan 27, 2019
Merged
antonbabenko added a commit that referenced this issue Jan 27, 2019
@antonbabenko
Tags should be possible to override (fixed #53) (#66)
e6d2f70
@antonbabenko
Copy link
Member

v1.14.0 has this fixed.

Thanks @metmajer for opening this issue and a nudge!

Sebor pushed a commit to Sebor/terraform-aws-ec2-instance that referenced this issue Aug 6, 2020
@antonbabenko
Tags should be possible to override (fixed terraform-aws-modules#53) (t…
ee88624 
…erraform-aws-modules#66)
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tags is now possible to override terraform-aws-modules/terraform-aws-ec2-instance
2 participants
@antonbabenko @metmajer