feat: Add support for multiple services inside `service_connect_con…

…figuration` (#123) feat: Add support for multiple service inside service_connect_configuration Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
terraform-aws-modules · Feb 12, 2024 · f0a628d · f0a628d
1 parent 2f04bba
commit f0a628d
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
@@ -107,14 +107,16 @@ module "ecs" {
 
       service_connect_configuration = {
         namespace = aws_service_discovery_http_namespace.this.arn
-        service = {
-          client_alias = {
-            port     = local.container_port
-            dns_name = local.container_name
+        service = [
+          {
+            client_alias = {
+              port     = local.container_port
+              dns_name = local.container_name
+            }
+            port_name      = local.container_name
+            discovery_name = local.container_name
           }
-          port_name      = local.container_name
-          discovery_name = local.container_name
-        }
+        ]
       }
 
       load_balancer = {

diff --git a/examples/fargate/main.tf b/examples/fargate/main.tf
@@ -126,14 +126,16 @@ module "ecs_service" {
 
   service_connect_configuration = {
     namespace = aws_service_discovery_http_namespace.this.arn
-    service = {
-      client_alias = {
-        port     = local.container_port
-        dns_name = local.container_name
+    service = [
+      {
+        client_alias = {
+          port     = local.container_port
+          dns_name = local.container_name
+        }
+        port_name      = local.container_name
+        discovery_name = local.container_name
       }
-      port_name      = local.container_name
-      discovery_name = local.container_name
-    }
+    ]
   }
 
   load_balancer = {

diff --git a/modules/service/main.tf b/modules/service/main.tf
@@ -153,7 +153,7 @@ resource "aws_ecs_service" "this" {
       namespace = lookup(service_connect_configuration.value, "namespace", null)
 
       dynamic "service" {
-        for_each = try([service_connect_configuration.value.service], [])
+        for_each = try(service_connect_configuration.value.service, [])
 
         content {
 
@@ -339,7 +339,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
       namespace = lookup(service_connect_configuration.value, "namespace", null)
 
       dynamic "service" {
-        for_each = try([service_connect_configuration.value.service], [])
+        for_each = try(service_connect_configuration.value.service, [])
 
         content {