Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace dynamic DNS suffix resolution for trusted service endpoints with static *.amazonaws.com #125

Merged
merged 6 commits into from
Oct 31, 2023
Merged

feat: Replace dynamic DNS suffix resolution for trusted service endpoints with static *.amazonaws.com #125

merged 6 commits into from
Oct 31, 2023

Commits on Oct 27, 2023

  1. Update main.tf 

    Hard coding it to amazonaws.com for identifiers. It is same in AWS China as well. I have created the resource manually in AWS China to test it. I was not able to create when I was using the value that is coming from data source (data.aws_partition.current.dns_suffix) which is amazonaws.com.cn. It accepts only amazonaws.com https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_execution_IAM_role.html#procedure_check_execution_role
    @hsalluri259
    hsalluri259 committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f035285 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. fix: Update all service trust endpoints to remove DNS suffix

    @bryantbiggs
    bryantbiggs committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d78d205 View commit details
    Browse the repository at this point in the history

  2. fix: Pre-commit does not like Linux

    @bryantbiggs
    bryantbiggs committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8ca3366 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into master

    @bryantbiggs
    bryantbiggs committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    efdadb4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into master

    @bryantbiggs
    bryantbiggs committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    9ef2525 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into master

    @bryantbiggs
    bryantbiggs committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    199ce21 View commit details
    Browse the repository at this point in the history