Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change back the default disk type to gp2 #1208

Merged
merged 3 commits into from
Apr 19, 2021
Merged

fix: Change back the default disk type to gp2 #1208

merged 3 commits into from
Apr 19, 2021

Conversation

barryib
Copy link
Member

@barryib barryib commented Jan 29, 2021

Reverts #1134

Resolves #1205

@barryib barryib mentioned this pull request Jan 29, 2021
Closed
3 tasks
@enkicoma
Copy link

enkicoma commented Feb 1, 2021 •
edited

@barryib can you please merge? "approved" 3 days ago

@benmangold
Copy link

benmangold commented Feb 1, 2021 •
edited

fwiw (for any encountering this) this can be configured back to gp2 via workers_group_defaults like this:

module "eks" {
  # ...
  workers_group_defaults {
    root_volume_type = "gp2"
  }
}

source from issue thread

@denisbr
Copy link

denisbr commented Feb 5, 2021

This is a pretty annoying bug, would be great to get this revert released! :)

@barryib barryib merged commit abdcfb7 into master Apr 19, 2021
@barryib barryib deleted the revert-1134-master branch April 19, 2021 20:54
@james-callahan james-callahan mentioned this pull request May 15, 2021
Merged
2 tasks
barryib added a commit to barryib/terraform-aws-eks that referenced this pull request May 20, 2021
@barryib
fix: Change back the default disk type to gp2 (terraform-aws-module…
e19e705 
…s#1208)
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DTTerastar DTTerastar DTTerastar approved these changes

@benmangold benmangold benmangold approved these changes

@nikitacr7 nikitacr7 nikitacr7 approved these changes

@enkicoma enkicoma enkicoma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidationError: gp3 is invalid
6 participants
@barryib @enkicoma @benmangold @denisbr @DTTerastar @nikitacr7