feat: Use gp3 as default as it saves 20% and is more performant
#1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayzalowitz
changed the title
|
@antonbabenko Any suggestion on getting that pull request linter working? |
barryib
changed the title
gp3 as default as it saves 20% and is more performant
|
This is a breking change. I will include this in the next major release (It's on his way ^^). |
barryib
approved these changes
Jan 28, 2021
|
I'm going to revert this change, since it breaks launch configuration usage. See #1205 for more info. cc @jayzalowitz |
|
Just hit this bug, any chance of a new release with that revert? |
ArchiFleKs
pushed a commit
to ArchiFleKs/terraform-aws-eks
that referenced
this pull request
Apr 16, 2021
…rraform-aws-modules#1134) BREAKING CHANGES: The default root volume type is now `gp3` as it saves 20% and is more performant
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Provider has caught up hashicorp/terraform-provider-aws#16652, thanks @ewbankkit
Description
AWS now has a cheaper and more performant drive type:
https://aws.amazon.com/about-aws/whats-new/2020/12/introducing-new-amazon-ebs-general-purpose-volumes-gp3/
Re: #1130
Checklist