Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Profile in kubeconfig template #39

Closed
1 task done
mschuchard opened this issue Jun 26, 2018 · 5 comments
Closed
1 task done

AWS Profile in kubeconfig template #39

mschuchard opened this issue Jun 26, 2018 · 5 comments

Comments

@mschuchard
Copy link

mschuchard commented Jun 26, 2018

I'm submitting a

  • feature request

For my current delivery, the customer has credentials with multiple profiles and not only needs to specify different profiles per cluster, but has no default profile.

It would be great if the kubeconfig.tpl could be modified:

...
users:
- name: aws
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1alpha1
      command: heptio-authenticator-aws
      args:
        - "token"
        - "-i"
        - "${cluster_name}"
      env:
        - name: AWS_PROFILE
          value: ${aws_profile}

where the default Terraform value to populate the template would be default to ensure no regression.

I wanted to start a discussion before a PR to ensure best path forward on this. Thanks!

@brandonjbjelland
Copy link
Contributor

Hi @mschuchard

This sounds good but I think this is a duplicate request. We just started discussing a similar (if not the same) issue here a day ago. Let me know if your use case can be accommodated by implementing what's proposed there.

@mschuchard
Copy link
Author

mschuchard commented Jun 27, 2018

I do not see any mention of implementing AWS profiles into the kubeconfig in that issue. Version 1.1.0 is currently failing for the customer because EKS cannot be reached due to the kubeconfig not using the correct AWs profile since that is not customizable in this module.

Having separate kubeconfigs is fine, but in reality people are likely going to be merging their kubeconfigs and then differentiating between them via context.

@sdavids13
Copy link
Contributor

I submitted PR #49 which provides the ability to specify a generic map of environment variables to be appended to the kubeconfig.

@brandonjbjelland
Copy link
Contributor

This is addressed having just merged #49 . Closing this up.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants