-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Kubeconfig to be more configurable #49
Allow Kubeconfig to be more configurable #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the most flexible way I've seen thus far to add configuration while still providing a minimal interface to get started. LGTM
|
||
variable "kubeconfig_context_name" { | ||
description = "Name of the kubeconfig context." | ||
default = "aws" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should default to the cluster name as aws
is very uninformative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I do agree (I configured my context name to be the cluster name as well). I was trying to limit the amount of changes made by default but if others think that is a more reasonable default I would be happy to provide another PR to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I just found that if you are trying to merge various EKS kubeconfigs together via the KUBECONFIG
environment variable the username needs to be unique across all of the config files. So, I will go ahead and make the change for both the context name and the user name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd all be appreciated @sdavids13 . Thanks for driving that
Correct. I've made a PR: #52 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Making Kubeconfig significantly more configurable in the following ways:
kubernetes
naming)Checklist
terraform fmt
andterraform validate
both work from the root andexamples/eks_test_fixture
directories (look in CI for an example)