fix: Add missing launch_template_use_name_prefix parameter to the root module
#1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
approved these changes
Jan 30, 2022
There was a problem hiding this comment.
thank you for catching this @efaif !
good to go @antonbabenko 👍🏽
antonbabenko
pushed a commit
that referenced
this pull request
Jan 30, 2022
### [18.2.4](v18.2.3...v18.2.4) (2022-01-30) ### Bug Fixes * add missing `launch_template_use_name_prefix` parameter to the root module ([#1818](#1818)) ([d6888b5](d6888b5))
|
This PR is included in version 18.2.4 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.2.4](terraform-aws-modules/terraform-aws-eks@v18.2.3...v18.2.4) (2022-01-30) ### Bug Fixes * add missing `launch_template_use_name_prefix` parameter to the root module ([#1818](terraform-aws-modules/terraform-aws-eks#1818)) ([abdaeb2](terraform-aws-modules/terraform-aws-eks@abdaeb2))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
launch_template_use_name_prefixparameter to the root moduleMotivation and Context
self-managed-node-group'slaunch_template_use_name_prefixvariable is not passed to the module, this PR is intended to solve thisHow Has This Been Tested?
self-managed-node-groupsub-module withlaunch_template_use_name_prefixset toTrue/Falseand verifying thataws_launch_templateresource'sname_prefix/namearguments are being set accordingly and the launch template is created as expected