feat: Make PGP Key Optional in All Cases

[p0fi]

Description

This will make the pgp_key argument optional in all configurations and add the unencrypted user password to the list of outputs. This will also raise the minimum required aws provider version to 4.1.0

Motivation and Context

When trying to create an iam user without a pgp_key but with an iam_user_login_profile the creation would fail.
Since version 4.1.0 of the aws provider the pgp_key argument of the resource aws_iam_user_login_profile is optional. Thus the constraint that a pgp_key is required when using create_iam_user_login_profile = true is not needed anymore.

👉 Terraform docs for aws_iam_user_login_profile (4.1.0)

Breaking Changes

No

How Has This Been Tested?

• I have tested and validated these changes using one or more of the provided examples/* projects

[bryantbiggs]

Thanks for the PR @p0fi - can you update the docs by running pre-commit run -a please

[p0fi]

Sorry for the dumb question, but how to do this? I checked brew and found a package called pre-commit and installed it. But running pre-commit run -a gives a lot of errors of seemingly missing tools. Is there somewhere a readme on how to update the docs? what tools should I have installed and so on.

[bryantbiggs]

ah yes, we should probably add that. Here is a link for now https://github.com/antonbabenko/pre-commit-terraform#how-to-install

[bryantbiggs]

Opened a PR to add this info FYI - terraform-aws-modules/.github#22

[p0fi]

Thanks for the link, the docker image worked well 🚀

[bryantbiggs]

thanks for the PR @p0fi - good to go @antonbabenko 👍🏽

[antonbabenko]

This PR is included in version 4.17.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.