Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code 1 on errors #91

Closed
ldormoy opened this issue Aug 6, 2020 · 4 comments · May be fixed by #157
Closed

Exit code 1 on errors #91

ldormoy opened this issue Aug 6, 2020 · 4 comments · May be fixed by #157

Comments

@ldormoy
Copy link

ldormoy commented Aug 6, 2020

Hello,

I recently encountered an HTTP 404 caused by an invalid Slack web hook URL (default channel got deleted in Slack, so the web hook got automatically disabled).

It took time to identify this issue because the Lambda monitoring reported a 100% success rate for this function.

I think it would make sense to set the exit code to 1 if the Slack response isn't a HTTP 200.

What do you think?

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 12, 2022
@github-actions
Copy link

This issue was automatically closed because of stale in 10 days

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants